-
Notifications
You must be signed in to change notification settings - Fork 31
feat(config): add ignore-existing for profile create #1094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): add ignore-existing for profile create #1094
Conversation
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
|
cc @rubenhoenle |
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
|
@dergeberl , pls run |
cgoetz-inovex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally, lgtm
Description
This PR adds
--ignore-existingas a flag forstackit config profile createin order to call the create idempotent and don not get a error in case the profile already exists. That make it possible to use profiles in automation/tool.Example: I am currently integrating stackit(-cli) into the gardenctl (gardener/gardenctl-v2#669).
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)